-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audit_trial_length_days attribute to ChatSummaryView response. #143
Add audit_trial_length_days attribute to ChatSummaryView response. #143
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
ce1c0e7
to
017d025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a question but not blocking... lgtm! Approved!
@@ -112,3 +112,28 @@ def user_role_is_staff(role): | |||
* bool: whether the user's role is that of a staff member | |||
""" | |||
return role in ('staff', 'instructor') | |||
|
|||
|
|||
def get_audit_trial_length_days(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea to move this!
@@ -492,22 +492,24 @@ class GetAuditTrialExpirationDateTests(TestCase): | |||
Test suite for get_audit_trial_expiration_date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice updates to tests!
017d025
to
badd952
Compare
In order for the frontend to know the currently configured trial length of an audit trial in days, an audit_trial_length attribute is added to the ChatSummaryView response. This property is supplied whether or not a learner has an audit trial. It represents the number of days in an audit trial as currently configured. It does not represent the number of days in the learner's current trial.
badd952
to
af9ee60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Jira: COSMO-603
In order for the frontend to know the trial length of an audit trial, a
audit_trial_length_days
attribute is added to theChatSummaryView
response.This property is supplied whether or not a learner has an audit trial. It represents the number of days in an audit trial as currently configured. It does not represent the number of days in the learner's current trial.