Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed Learning Assistant History endpoint #126

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

rijuma
Copy link
Member

@rijuma rijuma commented Nov 6, 2024

When fetching the course history, an error 500 was being produced by the endpoint produced by an InvalidKeyError.

This fixes the issue.

Copy link

github-actions bot commented Nov 6, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  learning_assistant
  api.py
  views.py
Project Total  

This report was generated by python-coverage-comment-action

@rijuma rijuma marked this pull request as ready for review November 6, 2024 19:42
@alangsto
Copy link
Member

alangsto commented Nov 6, 2024

Are there any tests that should be updated for these changes?

@rijuma
Copy link
Member Author

rijuma commented Nov 6, 2024

Are there any tests that should be updated for these changes?

Indeed, although the tests didn't seem to process the keys in the same way as the live code, since it was not failing. I've updated the tests accordingly. We can discuss it further if you want.

@rijuma rijuma merged commit 1d734a9 into main Nov 6, 2024
4 checks passed
@rijuma rijuma deleted the rijuma/fixed-courseware-history-key branch November 6, 2024 19:54
@rijuma rijuma changed the title fix: Fixed Couseware History fetching endpoint fix: Fixed Learning Assistant History fetching endpoint Nov 6, 2024
@rijuma rijuma changed the title fix: Fixed Learning Assistant History fetching endpoint fix: Fixed Learning Assistant History endpoint Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants