Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove demographics Snowflake cleanup job #1781

Merged
merged 1 commit into from
Sep 5, 2024
Merged

feat!: remove demographics Snowflake cleanup job #1781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 0 additions & 53 deletions dataeng/jobs/analytics/SnowflakeDemographicsCleanup.groovy
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions dataeng/jobs/createJobs.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import static analytics.JenkinsBackup.job as JenkinsBackupJob
import static analytics.PipelineAcceptanceTestManual.job as PipelineAcceptanceTestManualJob
import static analytics.PipelineAcceptanceTestMaster.job as PipelineAcceptanceTestMasterJob
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here? is this tabs to spaces or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea! That's how it's always looked for as long as I can remember: https://github.com/edx/jenkins-job-dsl/blob/master/dataeng/jobs/createJobs.groovy.

import static analytics.ReadReplicaExportToS3.job as ReadReplicaExportToS3Job
import static analytics.SnowflakeDemographicsCleanup.job as SnowflakeDemographicsCleanupJob
import static analytics.SnowflakePublicGrantsCleaner.job as SnowflakePublicGrantsCleanerJob
import static analytics.SnowflakeRefreshSnowpipe.job as SnowflakeRefreshSnowpipeJob
import static analytics.SnowflakeReplicaImportFromS3.job as SnowflakeReplicaImportFromS3Job
Expand Down Expand Up @@ -49,7 +48,6 @@ def taskMap = [
PIPELINE_ACCEPTANCE_TEST_MANUAL_JOB: PipelineAcceptanceTestManualJob,
PIPELINE_ACCEPTANCE_TEST_MASTER_JOB: PipelineAcceptanceTestMasterJob,
READ_REPLICA_EXPORT_TO_S3_JOB: ReadReplicaExportToS3Job,
SNOWFLAKE_DEMOGRAPHICS_CLEANUP_JOB: SnowflakeDemographicsCleanupJob,
SNOWFLAKE_PUBLIC_GRANTS_CLEANER_JOB: SnowflakePublicGrantsCleanerJob,
SNOWFLAKE_REFRESH_SNOWPIPE_JOB: SnowflakeRefreshSnowpipeJob,
SNOWFLAKE_REPLICA_IMPORT_FROM_S3_JOB: SnowflakeReplicaImportFromS3Job,
Expand Down Expand Up @@ -121,7 +119,6 @@ listView('Tools') {
name('data_engineering_seed_job')
name('stitch-snowflake-lag-monitor')
name('snowflake-public-grants-cleaner')
name('snowflake-demographics-cleanup')
}
columns DEFAULT_VIEW.call()
}
Expand Down
28 changes: 0 additions & 28 deletions dataeng/resources/snowflake-demographics-cleanup.sh
View file
Open in desktop

This file was deleted.

Loading