Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Xblock external UI - Server-side integration - #6

Merged
antoviaque merged 1 commit into
masterfrom
xblock-external-ui-solutions
Apr 11, 2014
Merged

Xblock external UI - Server-side integration#6
antoviaque merged 1 commit into
masterfrom
xblock-external-ui-solutions

Conversation

@antoviaque

Copy link
Copy Markdown

@martynjames @fredsmith This is the PR for the LMS integration of XBlocks we discussed yesterday.

Included commits:
* xblock-external-ui: Include CSRF token in the API answer
* xblock-external-ui: Adds support for CORS headers (cross-domain request)
* xblock-external-ui: Include full path when building local_url
@fredsmith

Copy link
Copy Markdown

👍

Comment thread lms/envs/common.py

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that I understand why this is here - I believe what's in ams.py (above) will set it anyway with the correct information; but I trust you! It all seems to work with this in place 😸

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, aws.py will set it correctly if it's used - but some people still don't use devstack for development, so aws.py is not always loaded for configuration, while common.py is.

@martynjames

Copy link
Copy Markdown

+1 👍

antoviaque added a commit that referenced this pull request Apr 11, 2014
Xblock external UI - Server-side integration
@antoviaque
antoviaque merged commit d80ce3c into master Apr 11, 2014
jareers pushed a commit that referenced this pull request Dec 28, 2015
jareers pushed a commit that referenced this pull request Dec 30, 2015
jareers pushed a commit that referenced this pull request Dec 30, 2015
…dback-update-7

Hash Update #6: Diagnostic-Feedback [Bug Fixes]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants