This repository was archived by the owner on Feb 26, 2024. It is now read-only.
[MCKIN-9474] [BB-873] Support for filters, and multiple roots in problem response reports - #1378
Merged
xitij2000 merged 1 commit intoFeb 20, 2019
Conversation
xitij2000
force-pushed
the
kshitij/enhanced-xblocks-reporting-solutions
branch
3 times, most recently
from
February 19, 2019 07:56
46099ee to
0465983
Compare
…report generation
xitij2000
force-pushed
the
kshitij/enhanced-xblocks-reporting-solutions
branch
from
February 19, 2019 10:39
0465983 to
5099b35
Compare
giovannicimolin
approved these changes
Feb 19, 2019
giovannicimolin
left a comment
There was a problem hiding this comment.
👍
- I tested this:
- I used the EdX Demo Course as base for testing this.
- Generate problem response reports for 2 problems sending comma-separated values.
- Checked that the report was correctly generated and responses for both problems were included ✔️
- Used section
block-v1:edX+DemoX+Demo_Course+type@chapter+block@graded_interactionsand tested theproblem_types_filterwith three values:
openassessmentproblemopenassessment,problem
- Checked that the generated reports contained only the problems that were specified on each operation ✔️
- Checked that we can generate a problem response report for the entire course with
block-v1:edX+DemoX+Demo_Course+type@course+block@course
- I read through the code
- Includes documentation: on the docstrings
-
I checked for accessibility issuesNA
Nice work! This is ready to merge. 😁
To make testing this easier, I logged in LMS on Chrome, generated a problem response report and copied a cURL request that looked like this:
curl 'http://lms.mcka.local/api/instructor/v1/course/course-v1:edX+DemoX+Demo_Course/reports/problem_responses' -H 'Pragma: no-cache' -H 'Origin: http://lms.mcka.local' -H 'Accept-Encoding: gzip, deflate' -H 'Accept-Language: en-US,en;q=0.9' -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.96 Safari/537.36' -H 'Content-Type: application/x-www-form-urlencoded; charset=UTF-8' -H 'Accept: application/json, text/javascript, */*; q=0.01' -H 'Cache-Control: no-cache' -H 'X-Requested-With: XMLHttpRequest' -H 'Cookie: openedx-language-preference=en; djdt=hide; csrftoken=nYvaNAd0020JjeC5B86H26T2mS2dKnMQ; sessionid=7czmuk4ij6r5c0ka3xitl5dbeql8mvmf' -H 'Connection: keep-alive' -H 'X-CSRFToken: nYvaNAd0020JjeC5B86H26T2mS2dKnMQ' -H 'Referer: http://lms.mcka.local/courses/course-v1:edX+DemoX+Demo_Course/instructor' --data 'problem_location=block-v1%3AedX%2BDemoX%2BDemo_Course%2Btype%40chapter%2Bblock%40graded_interactions' --compressed
| " To view the status of the report, see Pending Tasks below." | ||
| ) | ||
| return JsonResponse({"status": success_status}) | ||
| return JsonResponse({"status": success_status, "task_id": task.task_id}) |
xitij2000
added a commit
that referenced
this pull request
Mar 19, 2019
…report generation (#1378) [MCKIN-9474] [BB-873] Support for filters, and multiple roots in problem response reports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two features to the problem response report API:
Support for specifying multiple root blocks.
With this feature, you can now pass a comma-separated list of problem locations, and the generated report will include both of them (and children).
Support for specifying a problem type filter.
This feature allows you to request a report for only one or more types of problems.
Re: https://github.com/edx/edx-platform/pull/19781