fix: align retirement PII annotations with current runtime behavior - #392
Merged
Conversation
fix: align retirement PII annotations with current runtime behavior
ttak-apphelix
approved these changes
Jul 17, 2026
There was a problem hiding this comment.
Pull request overview
Updates PII retirement annotations on select LMS models so the code-annotation report reflects how user retirement is currently handled in runtime for those data stores.
Changes:
- Updated
verify_studentmodel docstring annotations to mark certain verification PII as retired vialocal_api. - Updated
SurveyAnswerPII retirement annotation fromretainedtolocal_api.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lms/djangoapps/verify_student/models.py | Adjusts .. pii_retirement annotations for verification-related models to better match retirement behavior. |
| lms/djangoapps/survey/models.py | Marks survey answer data as retired via local retirement API (model-level retirement method). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates pii_retirement annotations to match the current retirement implementation.
Changes
verify_studentverification annotations from retained to local_api where retirement already redacts or deletes datasurvey answerannotation from retained to local_apiNotes
certificate historyas retained because runtime still retains it by defaultReference Ticket & Confluence Page