feat: decouple enterprise from course start-date validation

[pwnage101]

Instead of enterprise-specific logic throwing an enterprise-specific start date validation error, CourseStartDateValidationFailed filter can now be used by plugins to throw a custom start date error.

ENT-11544

---

blocked by:

• feat: add CoursewareViewStarted, CourseStartDateValidationFailed, and CoursewareAccessChecksRequested filters openedx/openedx-filters#336
• feat: add several courseware access related pipeline steps openedx/edx-enterprise#2548
• feat: decouple enterprise from courseware view redirects #338

blocks:

• feat: decouple enterprise from course access checks #340
• feat: decouple enterprise from courseware view redirects, course start-date validation, and course access checks openedx/openedx-platform#38102

---

Integration Testing

I ran scripts/provision-integration-test-ENT-11544.sh then manually tested the following scenarios in devstack:

1. Enterprise learner has a subsidized enrollment in a future course:
   • Test: Login as enterprise_learner_test-enterprise@example.com then try to load http://localhost:2010/course/course-v1:edX+FutureX+2027
   • Expected: get redirected to enterprise learner dashboard.
2. Enterprise learner has a subsidized enrollment in an unscheduled course:
   • Test: Login as enterprise_learner_test-enterprise@example.com then try to load http://localhost:2010/course/course-v1:edX+UnschedX+TBD
   • Expected: get redirected to enterprise learner dashboard.
3. Enterprise learner has a NON-subsidized enrollment in a future course:
   • Test: Login as test-enterprise_learner_2@example.com then try to load http://localhost:2010/course/course-v1:edX+FutureX+2027
   • Expected: get redirected to LMS learner dashboard.
4. NON-enterprise learner has a NON-subsidized enrolled in a future course:
   • Test: Login as audit@example.com then try to load http://localhost:2010/course/course-v1:edX+FutureX+2027
   • Expected: get redirected to LMS learner dashboard.
     audit@example.com

[Copilot]

Pull request overview

This PR decouples enterprise-specific behavior from the core course start-date access check by introducing an Open edX Filters hook (CourseStartDateValidationFailed) that lets plugins substitute a custom start-date error payload, instead of hard-coding enterprise-specific errors in edx-platform.

Changes:

• Replaced enterprise-specific start-date error branching with a CourseStartDateValidationFailed filter hook in check_start_date.
• Extended StartDateError to support optional error-code and message overrides, and removed the dedicated StartDateEnterpriseLearnerError.
• Updated/trimmed tests to remove enterprise enrollment setup and to validate the new filter override behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
lms/djangoapps/courseware/access_utils.py	Runs CourseStartDateValidationFailed on start-date denial and converts filter overrides into StartDateError overrides.
lms/djangoapps/courseware/access_response.py	Adds override fields to StartDateError and removes the enterprise-specific start-date error class.
lms/djangoapps/courseware/tests/test_views.py	Updates access-utils tests to mock the new filter override path instead of enterprise enrollment plumbing.
lms/djangoapps/courseware/tests/test_access.py	Removes enterprise-specific query-count test and renames the remaining query-count test.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

[kiram15]

This looks good! Should we consider pinning the openedx-filters version?

[pwnage101]

openedx-filters has already been pinned to the version I need in the previous PR: #338