-
Notifications
You must be signed in to change notification settings - Fork 15
fix: upgrade ora2 dependency to version 6.17.2 and remove loremipsum d… #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
51fc613
ddf0675
074c8f0
21364b1
4de3bb5
c7d6ed2
04f72b3
3427f64
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -713,8 +713,6 @@ lazy==1.6 | |
| # lti-consumer-xblock | ||
| # ora2 | ||
| # xblock | ||
| loremipsum==1.0.5 | ||
| # via ora2 | ||
| lti-consumer-xblock==9.14.2 | ||
| # via -r requirements/edx/kernel.in | ||
| lxml[html-clean]==5.3.2 | ||
|
|
@@ -845,7 +843,7 @@ openedx-learning==0.27.1 | |
| # -r requirements/edx/kernel.in | ||
| optimizely-sdk==5.2.0 | ||
| # via -r requirements/edx/bundled.in | ||
| ora2==6.16.4 | ||
| ora2==6.17.2 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hm. Copilot is right that If this doesn't fix it and we still run into issues, we could consider addressing this issue and contributing the change upstream.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for catching this. bundled.in is included via base.in, so I agree there is a theoretical possibility of future resolves selecting a different version. However, this override pattern matches the current approach used in upstream edx-platform, and the explicit pin in base.txt ensures the compiled requirements use ora2==6.17.2. Given that, I'd prefer to keep this aligned with upstream for now and revisit updating the source constraint if we continue to see dependency resolution issues. |
||
| # via -r requirements/edx/bundled.in | ||
| packaging==25.0 | ||
| # via | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.