Skip to content

fix: prevent entrance exam minimum from being set to None #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jansenk merged 3 commits into from
Apr 6, 2026
Merged

fix: prevent entrance exam minimum from being set to None #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7b114b
fix: prevent entrance exam minimum from being set to None
jansenk Apr 6, 2026
a0bcef8
test: add test
jansenk Apr 6, 2026
e8611f5
fixup! test: add test
jansenk Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openedx/core/djangoapps/content/course_overviews/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ def _create_or_update(cls, course): # lint-amnesty, pylint: disable=too-many-st
# it to be a float like everything else.
if isinstance(course.entrance_exam_minimum_score_pct, int):
course_overview.entrance_exam_minimum_score_pct = course.entrance_exam_minimum_score_pct / 100
else:
elif course.entrance_exam_minimum_score_pct is not None:
course_overview.entrance_exam_minimum_score_pct = course.entrance_exam_minimum_score_pct
Comment thread
jansenk marked this conversation as resolved.
Comment thread
jansenk marked this conversation as resolved.

course_overview.force_on_flexible_peer_openassessments = course.force_on_flexible_peer_openassessments
Expand Down
10 changes: 10 additions & 0 deletions openedx/core/djangoapps/content/course_overviews/tests/test_course_overviews.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,16 @@ def test_mongo_course_overview_generation(self):
CourseOverview.load_from_module_store(course_key)
assert CourseOverview.objects.filter(id=course_key).exists()

def test_null_entrance_exam_minimum_score(self):
"""
Tests that course overview can be created when entrance_exam_minimum_score is null.
Comment thread
jansenk marked this conversation as resolved.
"""
course = CourseFactory.create()
course.entrance_exam_minimum_score_pct = None
course_overview = CourseOverview._create_or_update(course) # pylint: disable=protected-access
assert course_overview.entrance_exam_minimum_score_pct == \
CourseOverview.entrance_exam_minimum_score_pct.field.default
Comment thread
jansenk marked this conversation as resolved.


Comment thread
jansenk marked this conversation as resolved.
@ddt.ddt
class CourseOverviewImageSetTestCase(ModuleStoreTestCase):
Expand Down
Loading