fix: picker crash #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnr
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
In response to the /v1/account/registration/ API, we're consistently receiving an empty element.
{
"value": "",
"name": "--",
"default": true
}
Considering this, we could simplify the solution to a single line change.
let filteredItems = items.filter { $0.value.localizedCaseInsensitiveContains(search) }
return filteredItems.isEmpty ? [PickerItem(key: "", value: "")] : filteredItem
There was a problem hiding this comment.
Yea, i saw that, but just noticed that this PickerView is using from different places.. from subtitles view for example.
shafqat-muneer
approved these changes
Aug 9, 2024
saeedbashir
pushed a commit
that referenced
this pull request
Aug 20, 2024
rnr
pushed a commit
that referenced
this pull request
Sep 6, 2024
rnr
added a commit
that referenced
this pull request
Sep 30, 2024
Co-authored-by: Vadim Kuznetsov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fix crash when after filter applying
PickerViewcrash withindex out of boundserror.