fix: [iOS] On Course "Home" tab the row height #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnr
approved these changes
Jul 17, 2024
| @@ -36,8 +45,7 @@ public extension UIApplication { | |||
| } | |||
|
|
|||
| var windowInsets: UIEdgeInsets { | |||
| guard let windowScene = UIApplication.shared.connectedScenes.first as? UIWindowScene, | |||
| let window = windowScene.windows.first else { | |||
| guard let window = windows?.first else { | |||
There was a problem hiding this comment.
could we use here guard let window = window - property added on line 18?
saeedbashir
approved these changes
Jul 17, 2024
done |
rnr
added a commit
that referenced
this pull request
Oct 1, 2024
fix: [iOS] On Course "Home" tab the row height
rnr
added a commit
that referenced
this pull request
Oct 8, 2024
* Merge pull request #23 from edx/small-fix-for-downloading-cancelling fix: fixes for downloading * chore: fix for Xcode 16 and after merge * Merge pull request #24 from edx/2U/fix/download-states fix: [iOS] On Course "Home" tab the row height * fix: after merge, deleted IAP part fix: [iOS] On Course "Home" tab the row height * Merge pull request #25 from edx/2U/feat/primary-horizontal feat: Landscape mode Improvement * fix: removed IAP part * chore: remove snack bar error for course dates info API on course home (#27) * Merge pull request #28 from shafqat-muneer/Shafqat/LEARNER-10020-ErrorHandling feat: Course Level Error Handling for Empty States * chore: remove IAP part after merging --------- Co-authored-by: Anton Yarmolenko <[email protected]> Co-authored-by: Saeed Bashir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[iOS] On Course "Home" tab the row height changes after a while openedx#483