This repository was archived by the owner on Nov 12, 2023. It is now read-only.
[SE-1199] Fix username hints for SSO - #8
Merged
pkulkark merged 3 commits intoJun 25, 2019
Merged
Conversation
pkulkark
force-pushed
the
pooja/gingko-fix-username-hints-with-SSO
branch
from
June 25, 2019 03:45
e2f75f6 to
a392bf7
Compare
pomegranited
approved these changes
Jun 25, 2019
pomegranited
left a comment
pomegranited
left a comment
There was a problem hiding this comment.
Thanks @pkulkark ! 👍 once my nit below is fixed, and tests are passing again.
- I tested this as described in the PR, using MOE (SAML), Facebook, and Google SSO.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -- uses existing feature flag
| settings.apply_settings(self.settings) | ||
| self.assertIn('enterprise.tpa_pipeline.handle_enterprise_logistration', self.settings.SOCIAL_AUTH_PIPELINE) | ||
|
|
||
| def test_apply_settings_avoids_default_username_check(self): |
There was a problem hiding this comment.
nit: could you add a test for the default setting of self.settings.SOCIAL_AUTH_CLEAN_USERNAMES = True too, just to be complete?
Author
|
Thanks @pomegranited. I added the test for default setting as well. Will merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of the username hints not working for SSO - Google, FB, SAML.
The fix essentially disables calling the default clean username method which filters out non-ascii characters.
Testing Instructions:
Reviewers:
@pomegranited