This repository was archived by the owner on Nov 12, 2023. It is now read-only.
SE-1152 Fix ccx visibility on catalog - #6
Merged
samuelallan72 merged 1 commit intoJun 12, 2019
Merged
Conversation
This works if COURSE_CATALOG_VISIBILITY_PERMISSION is the default (`see_exists`) or `see_in_catalog`. (cherry picked from commit 857c5e26569fcaafce2b00161fde4ffbcec61326)
samuelallan72
force-pushed
the
samuel/fix-ccx-visibility-ginkgo
branch
from
June 11, 2019 08:13
d7d56d7 to
b44713f
Compare
samuelallan72
changed the title
pomegranited
approved these changes
Jun 11, 2019
pomegranited
left a comment
pomegranited
left a comment
There was a problem hiding this comment.
👍 once tests pass, thanks @swalladge !
- I tested this according to the PR instructions on my Campus devstack with their configuration, which includes
COURSE_CATALOG_VISIBILITY_PERMISSION: "see_in_catalog".
Verified that CCX courses no longer appear in the /courses list. - I checked the code against the original https://github.com/edx/edx-platform/pull/20746
samuelallan72
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hides all ccx courses from the course catalog. Previously the catalog visibility was inherited from the base course at the time of ccx creation, resulting in the possibility of ccx courses to be unexpectedly visible in the catalog.
Dependencies: None
Sandbox URL:
Merge deadline: None
Testing instructions:
CUSTOM_COURSES_EDX: true)COURSE_CATALOG_VISIBILITY_PERMISSIONset tosee_in_catalogAuthor notes and concerns:
see_exists, which renders thecatalog_visibilityadvanced course setting useless.Settings