Improve auto generation of release notes #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test runs on windows-latest for commit 2e8931d✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v6.0---- ## Run Summary Overall Result: ✔️ Pass Run Duration: 3s 910ms GitHub Runner OS: windows-latest Operating System: Microsoft Windows 10.0.20348 Framework: .NETCoreApp,Version=v6.0 Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll
Informational✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v6.0---- ## Run Summary Overall Result: ✔️ Pass Run Duration: 11s 436ms GitHub Runner OS: windows-latest Operating System: Microsoft Windows 10.0.20348 Framework: .NETCoreApp,Version=v6.0 Assembly: DotNet.Sdk.Extensions.Tests.dll
Informational✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v7.0---- ## Run Summary Overall Result: ✔️ Pass Run Duration: 2s 193ms GitHub Runner OS: windows-latest Operating System: Microsoft Windows 10.0.20348 Framework: .NETCoreApp,Version=v7.0 Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll
Informational✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v7.0---- ## Run Summary Overall Result: ✔️ Pass Run Duration: 11s 8ms GitHub Runner OS: windows-latest Operating System: Microsoft Windows 10.0.20348 Framework: .NETCoreApp,Version=v7.0 Assembly: DotNet.Sdk.Extensions.Tests.dll
Informational |
Test runs on ubuntu-latest for commit 2e8931d✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v6.0---- ## Run Summary Overall Result: ✔️ Pass Run Duration: 3s 826ms GitHub Runner OS: ubuntu-latest Operating System: Linux 5.15.0-1042-azure #49-Ubuntu SMP Tue Jul 11 17:28:46 UTC 2023 Framework: .NETCoreApp,Version=v6.0 Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll
Informational✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v6.0---- ## Run Summary Overall Result: ✔️ Pass Run Duration: 11s 351ms GitHub Runner OS: ubuntu-latest Operating System: Linux 5.15.0-1042-azure #49-Ubuntu SMP Tue Jul 11 17:28:46 UTC 2023 Framework: .NETCoreApp,Version=v6.0 Assembly: DotNet.Sdk.Extensions.Tests.dll
Informational✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v7.0---- ## Run Summary Overall Result: ✔️ Pass Run Duration: 4s 168ms GitHub Runner OS: ubuntu-latest Operating System: Linux 5.15.0-1042-azure #49-Ubuntu SMP Tue Jul 11 17:28:46 UTC 2023 Framework: .NETCoreApp,Version=v7.0 Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll
Informational✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v7.0---- ## Run Summary Overall Result: ✔️ Pass Run Duration: 11s 210ms GitHub Runner OS: ubuntu-latest Operating System: Linux 5.15.0-1042-azure #49-Ubuntu SMP Tue Jul 11 17:28:46 UTC 2023 Framework: .NETCoreApp,Version=v7.0 Assembly: DotNet.Sdk.Extensions.Tests.dll
Informational |
Codecov Report
@@ Coverage Diff @@
## main #734 +/- ##
=======================================
Coverage 86.72% 86.72%
=======================================
Files 77 77
Lines 1409 1409
Branches 219 219
=======================================
Hits 1222 1222
Misses 100 100
Partials 87 87 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edumserrano
added a commit
that referenced
this pull request
Aug 12, 2023
edumserrano
added a commit
that referenced
this pull request
Aug 12, 2023
edumserrano
added a commit
that referenced
this pull request
Aug 13, 2023
edumserrano
added a commit
that referenced
this pull request
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR I was delegating the generation of release notes to the ncipollo/release-action. However I soon found myself requiring to specify the
previous tagwhen auto generating release notes which this action did not support.In my case the problem is that I publish two NuGet packages from this repo and for the auto generated release notes to be accurate I need them to be generated between the last release tags for each NuGet package release, not just for whatever is the latest tag.
For instance, if I have the following releases:
nuget-a-v3nuget-b-v2nuget-a-v2And now I'm going to do a release with for
nuget-b, let's saynuget-b-v3then I want the release notes to be generated by comparing the tagnuget-b-v2andnuget-b-v3. By default that's not what was happening before this PR, it would grab the latest tab and would generated release notes between the tagnuget-a-v3andnuget-b-v3which didn't make sense.This PR takes the suggestion from ncipollo/release-action#198 and calls the generate release notes GitHub endpoint and then passes the resulting output to the ncipollo/release-action.
Note