Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SESSION_COOKIE_AGE and ruff.toml #152

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

Iso5786
Copy link
Contributor

@Iso5786 Iso5786 commented Oct 29, 2024

@Iso5786 Iso5786 requested a review from a team October 29, 2024 11:47
Copy link
Contributor

@berkes berkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Mogelijk is de logger wel een puntje, maar ik denk van niet. Zie comment bij eerste commit.

'backupCount': 30*24, # 30 days times 24 hours
'filename': os.path.join(LOGS_DIR, 'badgr_debug.log')
},
'badgr_debug_console': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan het zijn dat deze met een rebase per ongeluk erin is gekomen?

Volgens mij kan het geen kwaad, dus geen blocker, maar mss even dubbelchecken?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, morgen even samen naar kijken.

@Iso5786 Iso5786 merged commit eaeb618 into develop Oct 30, 2024
4 checks passed
@Iso5786 Iso5786 deleted the feature/session_exp branch October 30, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants