feat: add set custom primary colors method in initialize flow - #6
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## ednx-release/mango.nelp #6 +/- ##
==========================================================
Coverage ? 82.13%
==========================================================
Files ? 38
Lines ? 957
Branches ? 175
==========================================================
Hits ? 786
Misses ? 159
Partials ? 12 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
As we talked via other channels, I think this is great and it would be even better if this allowed for the optional inclusion of a css variables file. This way we can continue developing the ways in which to get you the css-variables without the need for a new deployment everytime. |
9372490 to
3a4a3fd
Compare
83e21ce to
ee0e1aa
Compare
| * @property {string} MFE_CONFIG_API_URL | ||
| * @property {string} APP_ID | ||
| * @property {string} SUPPORT_URL | ||
| * @property {string} CUSTOM_PRIMARY_COLORS |
There was a problem hiding this comment.
This should be an object instead of a string property
| * priority otherwise the level will be calculated based on primary color by | ||
| * using the mix function. | ||
| */ | ||
| export async function setCustomPrimaryColors() { |
There was a problem hiding this comment.
This function doesn't have any process async then you should remove this world
| // Configuration | ||
| await handlers.config(); | ||
| await runtimeConfig(); | ||
| await setCustomPrimaryColors(); |
There was a problem hiding this comment.
Await is not necessary here because the function doesn't return a promise.
aa9d98b to
3b9672d
Compare
Description:
This allows to set css custom properties, in this case just primary colors, in order to take advantage of this changes eduNEXT/paragon#1
How to test
Result will be something like this
