Skip to content

DEPR-66 Remove pattern library on programs_details - #170

Closed
AuraAlba wants to merge 4 commits into
masterfrom
ama/DEPR-66
Closed

DEPR-66 Remove pattern library on programs_details#170
AuraAlba wants to merge 4 commits into
masterfrom
ama/DEPR-66

Conversation

@AuraAlba

Copy link
Copy Markdown

Ticket on jira: https://openedx.atlassian.net/browse/DEPR-66
Add bootstrap main to remove pattern library. Add views for programs details to bootstrap main.
programs-bef
programs-12-03

@AuraAlba
AuraAlba requested a review from felipemontoya March 12, 2020 21:18

@felipemontoya felipemontoya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this having an effect in the program-detail view and also a different view.
Could you please remind me which that was? How difficult would it be to add it here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is going to be deleted, lets delete it. If it is just a temporary comment, please leave a note saying why it is temporary

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete or mark temp

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete or mark temp

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment should be gone since we are precisely removing pattern library

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmalBas I suppose that if you are adding all this new definitions, you are actually getting them from some other place. We should be removing them there, but I don't see this in this PR.

Could you please link the place where this was before?

@AuraAlba
AuraAlba force-pushed the ama/DEPR-66 branch 6 times, most recently from b3ae8a8 to 1f71ac6 Compare March 16, 2020 15:33
@AuraAlba
AuraAlba force-pushed the ama/DEPR-66 branch 4 times, most recently from d0cd0a9 to 10951f3 Compare April 30, 2020 01:12
@felipemontoya

Copy link
Copy Markdown
Member

@AmalBas can we close this internal PR?

@AuraAlba

Copy link
Copy Markdown
Author

@felipemontoya Yes. I'm going to close it.

@AuraAlba AuraAlba closed this Apr 30, 2020
cruise-control-service pushed a commit that referenced this pull request Jul 22, 2020
PROD-1236: Do not expose user id with certificate URL.
@felipemontoya
felipemontoya deleted the ama/DEPR-66 branch August 24, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants