li/ednx/JD-1: JD-1 Microsite aware key-secret pairs for oauth - #601
Merged
Conversation
Contributor
Author
|
Currently fixing tests 😪 |
mariajgrimaldi
requested review from
JuanDavidBuitrago,
MaferMazu,
MoisesGSalas,
jfavellar90,
johanseto and
magajh
December 17, 2021 20:56
mariajgrimaldi
force-pushed
the
li/ednx/JD-1
branch
from
December 17, 2021 21:29
8af0051 to
6418731
Compare
mariajgrimaldi
commented
Dec 20, 2021
| ] | ||
| assert disabled_provider.provider_id not in provider_ids | ||
|
|
||
| def test_tpa_hint_no_log_hidden_provider_displayed_for_login(self): |
Contributor
Author
There was a problem hiding this comment.
We divide these tests for a weird cache behavior.
mariajgrimaldi
commented
Dec 20, 2021
|
|
||
| # This is necessary because cms does not implement third party auth | ||
| @unittest.skipUnless(TPA_FEATURE_ENABLED, TPA_FEATURES_KEY + " not enabled") | ||
| @pytest.mark.skip(reason="fails due to unknown reasons (LI)") |
Contributor
Author
There was a problem hiding this comment.
These two test fail in remote environments but in local they pass:
Local:
mariajgrimaldi
force-pushed
the
li/ednx/JD-1
branch
2 times, most recently
from
December 20, 2021 11:59
5cf004b to
681e55c
Compare
Contributor
Author
|
Tests are failing for an unknown reason: Can you help me check what's happening @MoisesGSalas? |
MoisesGSalas
force-pushed
the
li/ednx/JD-1
branch
from
December 23, 2021 16:23
681e55c to
e9d8a40
Compare
MoisesGSalas
approved these changes
Dec 23, 2021
Member
This should fix the issue #606, but you will see new pylint errors. These were always there, but were silenced because paver didn't return a non 0 exit code when it encountered an import error. |
mariajgrimaldi
force-pushed
the
li/ednx/JD-1
branch
3 times, most recently
from
December 28, 2021 12:44
3c9cc84 to
25cd926
Compare
magajh
approved these changes
Dec 28, 2021
- Change KEY_FIELD from KEY_FIELDS = ('backend_name') to KEY_FIELDS = ('site_id', 'backend_name')
- Override provider_id to cast field
- Override current method to pass site_id
mariajgrimaldi
force-pushed
the
li/ednx/JD-1
branch
from
December 28, 2021 13:48
25cd926 to
b0922d6
Compare
MaferMazu
approved these changes
Dec 28, 2021
JuanDavidBuitrago
approved these changes
Dec 28, 2021
MaferMazu
changed the title
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows us to create an Oauth2 configuration for each site with different backends, enabling multitenancy.
A more detailed description of these changes: #433
How to test
'ENABLE_THIRD_PARTY_AUTH': True,Checkout this document on how to configure your Google provider
2. List Oauth2 Configurations:
Before changes (optional)
With JD-1
If your site/provider is well configured then you'll be able to register and login to your site.
Tested on stage
Before, one configuration per backend
After, one configuration per site, backend.
Now, login using google:
