Skip to content

Do not hide all the elements of the units with problems to anonymous … #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morenol merged 1 commit into from
Feb 24, 2020
Merged

Do not hide all the elements of the units with problems to anonymous … #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions common/lib/xmodule/xmodule/seq_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,13 +465,6 @@ def _render_student_view_for_items(self, context, display_items, fragment, view=
item_type = item.get_icon_class()
usage_id = item.scope_ids.usage_id

if item_type == 'problem' and not is_user_authenticated:

@cocococosti cocococosti Nov 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: the whole block is classified as "problem" if there is a graded element in it?

@morenol morenol Nov 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is being used the icon class to define the type of an unit. If there is a component(child) in the unit with 'problem' as icon class then the icon class of the unit is "problem". Those cases are the ones that are failing.

@cocococosti cocococosti Nov 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, they said it in the comments, getting the type from the icon class is kinda weird

log.info(
'Problem [%s] was not rendered because anonymous access is not allowed for graded content',
usage_id
)
continue

show_bookmark_button = False
is_bookmarked = False

Expand Down