Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on WASM #35

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix build on WASM #35

merged 1 commit into from
Oct 9, 2024

Conversation

ajalab
Copy link
Contributor

@ajalab ajalab commented Oct 8, 2024

This PR adds mmap_wasm.go file to allow dependent projects to compile for wasm architecture. It should resolve the issue #24.

The added file is mostly equivalent to mmap_plan9.go introduced in #25, except for the use of syscall.ENOTSUP. This errno is used by the standard library such as syscall.AllThreadsSyscall.

This was referenced Oct 8, 2024
Closed
Merged
edsrzf
edsrzf approved these changes Oct 9, 2024
View reviewed changes
Copy link
Owner

@edsrzf edsrzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@edsrzf edsrzf merged commit d20d143 into edsrzf:main Oct 9, 2024
@ajalab ajalab deleted the support-wasm branch October 9, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsrzf edsrzf edsrzf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajalab @edsrzf