Add .packit.yml #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ed Santiago <[email protected]>
|
There was an error while creating SRPM. You can re-trigger build by adding a comment ( Output: |
|
The file you link in the packit config - If you have a command that generates the file, actions are a preferred way to do it: |
edsantiago
added a commit
that referenced
this pull request
Feb 18, 2020
As I've mentioned once or twice, hand-maintained swagger docs
are evil. This commit attempts to fix:
* Inconsistent methods (swagger says POST but code signature
says GET)
* Inconsistent capitalization
* Typos ("Mounter", "pood")
* Completely wrong paths (/inspect vs /json)
* Missing .Method() registrations
* Missing /libpod in some /volumes paths
* Incorrect method declaration: /libpod/containers/.../kill
was correct (POST) in swagger but wrong in the code itself
(http.MethodGet). Correct the latter to MethodPost
This is two hours' work, even with a script I have that
tries to cross-check everything.
Swagger docs should not be human-maintained.
Signed-off-by: Ed Santiago <[email protected]>
edsantiago
pushed a commit
that referenced
this pull request
Feb 19, 2020
Add API review comments to correct documentation and endpoints. Also, add a libpode prune method to reduce code duplication. Only used right now for the API but when the remote client is wired, we will switch over there too. Signed-off-by: Brent Baude <[email protected]>
edsantiago
pushed a commit
that referenced
this pull request
Feb 19, 2020
Review corrections pass #2
edsantiago
pushed a commit
that referenced
this pull request
Feb 19, 2020
Swagger: fix inconsistencies (try #2)
|
A friendly reminder that this PR had no activity for 30 days. |
edsantiago
pushed a commit
that referenced
this pull request
Jun 25, 2020
Friendly amendment for pr 6751
edsantiago
pushed a commit
that referenced
this pull request
Jan 24, 2022
Fix #2 for compat commit handling of --changes
edsantiago
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Use vfkit command line assembly * Inject ignition file into guest using http over vsock * Ready notification through use of vsock [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
edsantiago
pushed a commit
that referenced
this pull request
Jul 11, 2023
AppleHV enablement pass #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ed Santiago [email protected]