Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REVIEW #5

Merged
merged 2 commits into from
Jun 28, 2024
Merged

REVIEW #5

merged 2 commits into from
Jun 28, 2024

Conversation

acocac
Copy link
Member

@acocac acocac commented Apr 19, 2024

Hi 👋

Thanks authors and reviewers to agree on collaboratively improving the submitted notebook to EDS book ✨

The review PR aims to facilitate a detailed discussion of how to improve the notebook via ReviewNB, a third-party plugin in GitHub for displaying and commenting Jupyter Notebooks. Find further details here. For general comments, please use the REVIEW issue containing the checklist.

Authors: please reply to reviewers' comments in a timely manner and push changes from your repository to this PR. You'll see ReviewNB easily renders Jupyter Notebook rich diffs than GitHub (see here).

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

Binder 👈 Test this PR on Binder

notebook.ipynb Show resolved Hide resolved
notebook.ipynb Show resolved Hide resolved
notebook.ipynb Show resolved Hide resolved
notebook.ipynb Show resolved Hide resolved
notebook.ipynb Show resolved Hide resolved
notebook.ipynb Show resolved Hide resolved
notebook.ipynb Show resolved Hide resolved
notebook.ipynb Show resolved Hide resolved
notebook.ipynb Show resolved Hide resolved
notebook.ipynb Show resolved Hide resolved
notebook.ipynb Show resolved Hide resolved
notebook.ipynb Show resolved Hide resolved
notebook.ipynb Show resolved Hide resolved
@acocac
Copy link
Member Author

acocac commented Jun 28, 2024

Merging into the main branch, however main changes were addressed in #6.

@acocac acocac merged commit 1e1633c into main Jun 28, 2024
1 check passed
acocac pushed a commit that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants