forked from bnubald/icenet-edsbook
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REVIEW #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
weiji14
reviewed
Apr 30, 2024
weiji14
reviewed
May 1, 2024
42 tasks
Merged
Merging into the main branch, however main changes were addressed in #6. |
acocac
pushed a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
Thanks authors and reviewers to agree on collaboratively improving the submitted notebook to EDS book ✨
The review PR aims to facilitate a detailed discussion of how to improve the notebook via ReviewNB, a third-party plugin in GitHub for displaying and commenting Jupyter Notebooks. Find further details here. For general comments, please use the REVIEW issue containing the checklist.
Authors: please reply to reviewers' comments in a timely manner and push changes from your repository to this PR. You'll see ReviewNB easily renders Jupyter Notebook rich diffs than GitHub (see here).