Fix Carthage Build Error #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Carthage Build Error
|
Hey @leedsalex, thanks for the pull request! Apologies for not responding to your issue, I got my hands full with my day-to-day work these few weeks. Definitely will check this out this evening. By the way, a suggestion from me - could you change the merge target to the develop branch? That way, I could update the CHANGELOG and test it on Cocoapods before releasing it... just to make sure 🤞 Cheers mate! |
|
Thanks @edopelawi I've switched the base branch to develop. |
|
@edopelawi Were you able to take a look at this pull request? |
|
Whoops, I missed this pull request. Works like a charm mate, merging this now! @leedsalex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Carthage build error experienced in Carthage version 0.26.2 (#16).
A small change was made to the project build settings to use Xcode Default build directory instead of a target defined build directory.