Swift 4 update #15
Swift 4 update #15
Conversation
|
@edopelawi Thank you for taking care of this for me in such a timely manner. |
|
Sure thing, @leedsalex! I'm still trying to get the configuration right for Travis CI's Xcode 9, could you use the branch directly (swift-4-update) from your Carthage / Cocoapods? I'll let you know when it's properly merged and released. |
…ion methods Prior to this commit, the project cannot compile because errors from DestinationInfoMapSectionDelegate, saying that Swift 4 doesn't allow overriding extension methods.
…Delegate methods with @objc declaration
…elegate methods with @objc declaration
… Delegate methods with @objc declaration
… and Delegate methods with @objc declaration
…nd Delegate methods with @objc declaration
…elegate methods with @objc declaration
This will be changed after 7.0.2 is ready.
This will be changed after the working version is ready.
|
@edopelawi Any update on your progress? Is there anything I can help with? |
This was skipped because Travis-CI's free builder can't clone using Cocoapods' custom branch parameters. I have run the test manually in machine to make sure all of them passed. I'll revert this after Quick and Nimble updated their version to run in Xcode 9 (9A235).
|
Hey @leedsalex, thanks for bumping this issue. Got caught in a middle of a busy project. The travis compile issue was caused by Nimble v7.0.2 and Quick v1.0.1 which can't run in Xcode 9. The Quick team already updated Nimble 7.0.2, but not with the Quick. I've posted an issue for it here. For the time being, I skipped running tests for my Travis build step. I have run all the tests in my machine to make sure that runs well. After the newest builds succeeds, I'll publish the newest version. Cheers, |
Per #14 's request.