Updated & Optimized #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardottt
reviewed
Oct 23, 2023
| @@ -46,9 +46,6 @@ def error_handler(e): | |||
| logger.info("Sleeping for five minutes.") | |||
| time.sleep(5 * 60) | |||
|
|
|||
| # for other types of issues with specific behaviour | |||
There was a problem hiding this comment.
is there a specific reason to delete this comment?
| @@ -56,7 +56,7 @@ def tweet_banner(message): | |||
| This is a standard tweet to spread info about the bot. | |||
| """ | |||
| tweet = str(datetime.datetime.now()) + "\n" | |||
| tweet += "This is a bot at the service of @" + globals.user + ".\n" | |||
| tweet += f"This is a bot at the service of @{globals.user}" + ".\n" | |||
There was a problem hiding this comment.
Here the final ".\n" is not included in the string
| _ = open(directory + "/" + filename, "w+") | ||
| if not os.path.exists(f"{directory}/{filename}"): | ||
| _ = open(f"{directory}/{filename}", "w+") | ||
| elif answer := ask_confirmation(): |
There was a problem hiding this comment.
What's the purpose of assigning answer here?
| if thread.getName() == "bot" and not thread.is_alive(): | ||
| return "error", 500 | ||
| return "ok" | ||
| return next( |
There was a problem hiding this comment.
Sorry, I'm not understanding this return statement...
| for i in range(0, len(values)): | ||
| result += values[i][2] | ||
| return str(result) | ||
| result = sum(values[i][2] for i in range(0, len(values))) |
| else: | ||
| result = values[0][3] | ||
| return str(result) | ||
| result = values[0][3] |
| @@ -39,11 +39,11 @@ def check_stat(username): | |||
| logger = logging.getLogger("matplotlib") | |||
| logger.setLevel(logging.CRITICAL) | |||
| logger = logging.getLogger("__main__") | |||
| dates = [] # contains all the dates stored in the database | |||
There was a problem hiding this comment.
What's the purpose of deleting the comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.