Skip to content
This repository has been archived by the owner on Jul 21, 2020. It is now read-only.

Android L optimisation #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

geometer
Copy link

Not sure this is a good solution for everyone because the patch increases memory usage. It just loads full archive entry content into memory in getInputStream(). However it changes performance drastically (50 times faster) on my Nexus 7 with Android 5.

Related to #17 and #31.

@venbab
Copy link

venbab commented Feb 2, 2015

HI Nikolay ,
thanks for your input.
Is it possible to write our own PipedStreams for solving this problem in Junar source code.i think that will be a better solution
http://www.staldal.nu/tech/2014/03/04/dont-use-pipedoutputstream-on-android/

is it possible to do ?

@geometer
Copy link
Author

geometer commented Feb 2, 2015

I think it makes no sense (for this task) to write piped streams working in two threads. “Correct” solution is to implement single-thread implementation that consists of

  1. some buffer;
  2. method for partial filling this buffer from archive;
  3. InputStream that reads from the buffer and calls 2) if needed.

On 2 Feb 2015, at 10:28, venbab [email protected] wrote:

HI Nikolay ,
thanks for your input.
Is it possible to write our own PipedStreams for solving this problem in Junar source code.i think that will be a better solution
http://www.staldal.nu/tech/2014/03/04/dont-use-pipedoutputstream-on-android/ http://www.staldal.nu/tech/2014/03/04/dont-use-pipedoutputstream-on-android/
is it possible to do ?


Reply to this email directly or view it on GitHub #33 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants