Fix typo (from Vim downstream) #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure help tags are supposed to be tracked by git? My understanding of help tags is that they should be generated by the user. In case of the vim runtime bundled with Vim, the help tags may be pregenerated so that users can use them sitewide. |
|
I am not very aware of what the convention is, other than that Vim itself keeps tags files committed to the repo. I looked at a few other extensions and they do not, though. I can drop the tags change from this PR leaving only the typo fix if you prefer.
|
|
Yes, please. |
Change copied from downstream Vim commit dbf749b (runtime: Fix more typos (#13354), 2023-10-16). Co-authored-by: Viktor Szépe <[email protected]>
gwymor
force-pushed
the
downstream-vim-changes
branch
from
049476d to
d9c0330
Compare
gwymor
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change copied from downstream Vim commit dbf749b (runtime: Fix more
typos (#13354), 2023-10-16).
Co-authored-by: Viktor Szépe [email protected]