Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #230

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Fix typo #230

merged 1 commit into from
Dec 2, 2023

Conversation

yous
Copy link
Contributor

@yous yous commented Dec 1, 2023

This fixes #224 (comment).

@xuhdev
Copy link
Member

xuhdev commented Dec 2, 2023 •
edited
Loading

Could you explain why l: should be replaced by a: here? I'm having a hard time finding out relevant docs.

This was referenced Dec 2, 2023
Closed
Closed
@nedbat
Copy link

nedbat commented Dec 2, 2023

a: references the arguments of a function. l: references variables local to a function. This function has no bufnr variable.
Details: https://vimhelp.org/eval.txt.html#variable-scope

xuhdev
xuhdev approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right -- I didn't notice bufnr is a function argument. Thanks for the fix!

@xuhdev xuhdev merged commit 95cb75e into editorconfig:master Dec 2, 2023
@yous yous deleted the fix-typo branch December 3, 2023 08:00
@fannheyward fannheyward mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuhdev xuhdev xuhdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cursor moves back to beginning of line when exiting :FZF popup on Vim 9 (after #209)
3 participants
@yous @xuhdev @nedbat