Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow symlinks for files #123

Closed
wants to merge 1 commit into from
Closed

Conversation

adriansm
Copy link

When linking files, the final file may be somewhere else where there may
be an .editorconfig file.

Example: ~/.gitconfig -> ~/dotfiles/git/config

By following symlinks, in this example the .editorconfig can remain at
~/dotfiles/git/.editorconfig

When linking files, the final file may be somewhere else where there may
be an .editorconfig file.

Example: ~/.gitconfig -> ~/dotfiles/git/config

By following symlinks, in this example the .editorconfig can remain at
~/dotfiles/git/.editorconfig
@cxw42
Copy link
Member

cxw42 commented Jul 19, 2019

Thanks for the contribution! I think this needs a specification discussion. Where the .editorconfig files are located should be consistent across editors. I'll ask around.

@xuhdev
Copy link
Member

xuhdev commented Jul 19, 2019

I don't think we should follow symlinks in the Vim, as this is consistently not followed in other core libraries. In your case, my suggestion is to add a quick file list in Vim so that you can quickly let Vim open these files directly, instead of vim /path/to/symlink.

@adriansm
Copy link
Author

This can also be solved with something like: https://stackoverflow.com/questions/30791692/make-vim-follow-symlinks-when-opening-files-from-command-line

However it seems more obvious to me to allow files to follow editorconfig options from the real location of file. That being said, agree that this should be consistent across editors

@xuhdev
Copy link
Member

xuhdev commented Jul 19, 2019

There are pros and cons for either approach. Thanks for your contribution and will close this now for the sake of consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants