Add Core

[10sr]

What is This?

Pull Request to add Core implemented in Emacs Lisp

Done

• Add core el files
  • From here
    • editorconfig-core
    • editorconfig-core-handle
  • From here
    • editorconfig-fnmatch
• Add files and a submodule to use to test core functions
• Update Makefile for core test
• Update document
• Update function to use el core as a fallback
  • As commented 👇, by default editorconfig-apply now first try to invoke editorconfig core executable, and fallback to elisp implementation if it is not found
  • I added new editorconfig-get-properties
    • It is set to be the default value of editorconfig-get-properties-function
    • Existing editorconfig-get-properties was renamed to editorconfig-call-editorconfig-exec: I think it is more suited
• Bump version
  • v0.6

I'll Do After Merge

• Deprecate my repositories
• Update MELPA recipe

[xuhdev]

I just have one comment here: after we add the core, I still suggest to use the external editorconfig command as the default way, and only if the extension cannot find them, we use the elisp implemented core. The reason is simple: we have the EditorConfig cores written in more common languages and we would have more support for them. While the elisp core is good work, we still want to make the world less discrepant if possible.

[10sr]

That's reasonable. I'll do so 🙋

[10sr]

NOTE: I'm going to wait #47 to be merged because I want to change the function name of editorconfig-get-properties.

[10sr]

Now I believe I've almost finished my work.
I will merge this PR in a few days, but please feel free to comment if you have something.

[xuhdev]

@10sr You don't have to wait for someone else to merge #47---If you think #47 is good enough, you can merge it yourself :)

[10sr]

Right! Thanks 😈

[xuhdev]

Just one comment, can you add the license header to this file as well? This file seems significantly long enough, so without a license header its license would be ambitious---since we have a license in the root directory but no license (proprietary by default) in the header.

[10sr]

Thanks! I'll add that tonight (about 6 hours later 😺) and also merge this PR.

[10sr]

8b85d91