Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ws-butler when enabled and available. #183

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Conversation

terlar
Copy link
Contributor

@terlar terlar commented Nov 17, 2018

When having auto-save on and you edit text the cleaning up of
white-space is a bit intrusive and removes the space at the end of the
line where you are writing. ws-butler-mode is an alternative that does
take this into account.

I understand if this might be unwanted, but I am opening this in hope that it would help someone else and to open a discussion. Perhaps as an alternative to implement the unobtrusive change in editorconfig-emacs itself.

When having auto-save on and you edit text the cleaning up of
white-space is a bit intrusive and removes the space at the end of the
line where you are writing. `ws-butler-mode` is an alternative that does
take this into account.
@10sr
Copy link
Member

10sr commented Nov 20, 2018

Thanks for your proposal! 👍
I agree it needs some more consideration, I'll try it later!

@10sr
Copy link
Member

10sr commented Dec 15, 2018

I pushed a new commit to add a new variable editorconfig-trim-whitespaces-mode instead.
With this now you can use ws-butler by adding following:

(setq editorconfig-trim-whitespaces-mode
      'ws-butler-mode)

I haven't check if this code acrually works yet, I'll do shortly!

I've checked it works!

@10sr 10sr merged commit f16d342 into editorconfig:master Dec 17, 2018
@terlar
Copy link
Contributor Author

terlar commented Jan 14, 2019

Nice solution, this should cover all use cases when it comes to whitespace trim configuration. Thanks, this has been a longtime itch of mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants