use CURDIR instead of PWD in Makefile #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During debian package build, the Makefile is called by debian/rules, which is also a Makefile. PWD is not propaged in recursive Makefile invocation, but CURDIR is: https://www.gnu.org/software/make/manual/html_node/Recursion.html found via: https://sourceforge.net/p/ipt-netflow/bugs-requests-patches/53/
xuhdev
approved these changes
Jul 22, 2018
10sr
approved these changes
Jul 23, 2018
|
I tested it locally and it passed 🙌 |
|
Perfect, I'll merge it. |
|
Sorry for taking a little time but I've just release v0.7.13 that includes this change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During debian package build, the Makefile is called by debian/rules, which is also a Makefile. PWD is not propaged in recursive Makefile invocation, but CURDIR is:
https://www.gnu.org/software/make/manual/html_node/Recursion.html
found via: https://sourceforge.net/p/ipt-netflow/bugs-requests-patches/53/