Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable to disable lisp-indent-offset sometimes #155

Merged
merged 2 commits into from
Apr 28, 2018

Conversation

jgkamat
Copy link
Contributor

@jgkamat jgkamat commented Apr 5, 2018

Sorry for the delay, I actually completely forgot about this...

I actually changed the spec of the variable from what I originally defined it as, the docstring is now:

Selectively ignore the value of indent_sizefor Lisp files.
Prevents `lisp-indent-offset' from being set selectively.

nil - `lisp-indent-offset' is always set normally.
t   - `lisp-indent-offset' is never set normally
       (always use default indent for lisps).
number - `lisp-indent-offset' is not set only if indent_size is
         equal to this number.  For example, if this is set to 2,
         `lisp-indent-offset'will not be set only if indent_size is 2.

Let me know if anything seems wrong here, since this is a pretty large change.

Closes #137

@@ -0,0 +1,5 @@
root = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better place this can go? I don't want it to go in the submodule, it seems specific to this plugin.

@10sr 10sr self-assigned this Apr 9, 2018
@10sr 10sr merged commit 1e82a9a into editorconfig:master Apr 28, 2018
@10sr
Copy link
Member

10sr commented Apr 28, 2018

Good! Thanks 🙌

@jgkamat jgkamat deleted the jay/lisp-default-offset branch April 28, 2018 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants