Fix test failures (can't find executable; CRLF) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update :) |
|
Not currently - do you have any thoughts or other test cases? I'll work on it as soon as I can. I have been following some of the notifications in other repos and I know this needs to be taken care of. |
xuhdev
reviewed
Oct 20, 2019
|
@xuhdev Updated per your comments, and CI tests pass on the linked PRs :) . |
xuhdev
reviewed
Oct 21, 2019
Fixes: - editorconfig#28 - The warning at https://ci.appveyor.com/project/xuhdev/editorconfig-core-c/builds/28235086/job/u9ebs7f3b9u3gowk#L1660 Major changes: - Always use add_test(NAME ... COMMAND ...): This is for consistency - add_test(NAME ... COMMAND ...) escapes differently than add_test(<name> <command>...). - Fix backslash escaping: Now that we are using the add_test(NAME ... COMMAND ...) form, backslash escaping works differently. In my tests, backslashes are not collapsed in that form. - Specify `-C Debug` on the `ctest` command line: This permits the Visual Studio generator to run tests.
|
Related PRs have passed CI tests. Thank you for your kind words! |
xuhdev
approved these changes
Oct 21, 2019
|
Merged. Very cool. Thanks! |
|
@xuhdev any plan to tag a new release? |
|
@greut editorconfig/editorconfig#395 I think it's time to formulate a voting about versioning scheme. After that, we should be able to start tagging, along with the spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @xuhdev - working on fixing #28. See details at #28 (comment) .
@editorconfig/developers Please see "Requirements on cores," below.
Overview
Requirements on cores
EDITORCONFIG_CMDto=<target name>rather than a path to the executable. That will cause the tests to get the executable's name from cmake. See, e.g., this example.Corresponding PRs I have been using to test these changes
These are currently draft, and I will submit them formally once this PR is merged.