Skip to content

Fix cursor navigation and backspace functionality CodeTool #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Fix cursor navigation and backspace functionality CodeTool #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79df8b9
Fix cursor navigation and backspace functionality CodeTool
idebenone Oct 30, 2024
f1bde0c
fix: remove event.preventDefault()
idebenone Nov 7, 2024
5156a33
fix: use textarea.value instead of textarea.textContent for setting a…
idebenone Nov 18, 2024
82b7a36
fix: configure dev server
idebenone Nov 19, 2024
5952ba5
fix: remove unwanted implementations
idebenone Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions dev/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Code Plugin Test | EditorJS</title>
</head>
<body>
<div id="editorjs"></div>
<script src="https://cdn.jsdelivr.net/npm/@editorjs/editorjs@latest"></script>
<script src="https://cdn.jsdelivr.net/npm/@editorjs/header@latest"></script>
<script type="module">
import CodeTool from '../src/index.ts';
const editor = new EditorJS({
holder: 'editorjs',
data: {
time: 1700475383740,
blocks: [
{
id: 'aRMoZePSTD',
type: 'header',
data: { text: 'Welcome to Editor.js', level: 2 },
},
{
id: 'fcG8CCR5F8',
type: 'code',
data: { code: 'print("Namaste World")' },
},
],
},
tools: {
code: CodeTool,
header: Header,
},
});
</script>
</body>
</html>
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@editorjs/code",
"version": "2.9.2",
"version": "2.9.3",
"keywords": [
"codex editor",
"code",
Expand Down
4 changes: 2 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export default class CodeTool implements BlockTool {
this._data = data;

if (this.nodes.textarea) {
this.nodes.textarea.textContent = data.code;
this.nodes.textarea.value = data.code;
}
}

Expand Down Expand Up @@ -299,7 +299,7 @@ export default class CodeTool implements BlockTool {

wrapper.classList.add(this.CSS.baseClass, this.CSS.wrapper);
textarea.classList.add(this.CSS.textarea, this.CSS.input);
textarea.textContent = this.data.code;
textarea.value = this.data.code;

textarea.placeholder = this.placeholder;

Expand Down
3 changes: 3 additions & 0 deletions vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ export default {
fileName: 'code',
},
},
server: {
open: './dev/index.html',
},
define: {
NODE_ENV: JSON.stringify(NODE_ENV),
VERSION: JSON.stringify(VERSION),
Expand Down
Loading