chore: adopt type-aware Oxc toolchain by edhor1608 · Pull Request #65 · edhor1608/passepartout

edhor1608 · 2026-07-22T17:18:52Z

What changed

replace Biome with the Oxc toolchain: type-aware Oxlint 1.75 and Oxfmt 0.60
add oxlint-tsgolint matched to the pinned TypeScript 7.0.2 compiler
enforce no-explicit-any, no-misused-promises, and the type-aware recommended rules
add Oxfmt writing and verification commands, with formatting verification in bun run check
normalize the eight files that differed from the committed Oxfmt configuration
document the toolchain decisions and quality-gate behavior

Why

Oxlint's stable type-aware engine now targets the same TypeScript 7.0.2 version used by this repository. Moving formatting to Oxfmt removes the remaining duplicate parser/tooling path and gives the project one explicit Oxc-based lint-and-format setup.

The independent tsc --noEmit step remains because Oxlint's compiler-diagnostic typeCheck option is still marked experimental. Import sorting remains disabled to keep ordering policy outside this migration.

Impact

bun run lint now performs semantic TypeScript linting. bun run format writes Oxfmt output, and the complete quality gate rejects formatting drift through bun run format:check.

Validation

bun install --frozen-lockfile
bun run check
- TypeScript 7 typecheck
- type-aware Oxlint
- Oxfmt check across 29 files
- 10 unit tests
- 10 FFmpeg integration tests
bun run prepare-image --help
git diff --check

Note

Replace Biome with type-aware Oxlint and Oxfmt toolchain

Removes Biome and adds oxlint 1.75.0, oxfmt 0.60.0, and oxlint-tsgolint with type-aware linting enabled via .oxlintrc.json.
Adds typescript/no-explicit-any and typescript/no-misused-promises as errors; maxWarnings is set to 0 so any warning fails the build.
Adds a format:check script (non-mutating) and includes it in the check pipeline alongside typechecking and linting.
Reformats several source files to comply with the new 100-character print width and style rules in .oxfmtrc.json; no logic changes.
Behavioral Change: lint and format scripts now invoke oxlint/oxfmt instead of Biome; existing Biome config is deleted.

^{Macroscope summarized b5fb824.}

Summary by CodeRabbit

Tooling
- Replaced Biome with Oxc tools for linting and formatting.
- Added stricter type-aware lint checks and format verification to the quality checks.
- Standardized formatting rules, including line width, quotes, semicolons, trailing commas, and package metadata ordering.
Documentation
- Updated project guidance and README quality-gate descriptions.
- Added decision-log entries documenting the updated validation and formatting standards.
Maintenance
- Reformatted CLI, image-processing, and test code without changing behavior.

edhor1608 · 2026-07-22T17:19:08Z

chore: adopt type-aware Oxc toolchain #65 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai · 2026-07-22T17:19:12Z

📝 Walkthrough

Walkthrough

The repository replaces Biome with Oxlint and Oxfmt, adds formatter and linter configuration, and extends bun run check with format verification. Documentation and decision records describe the updated TypeScript, lint, formatting, and test gates. Existing source and test files receive formatting-only changes with behavior and assertions preserved.

Possibly related PRs

edhor1608/passepartout#58: Overlaps with the reformatted image-preparation CLI, domain, and integration-test files.
edhor1608/passepartout#62: Both changes touch FFprobe path-resolution logic in src/domain/media_process.ts.

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

Ignore

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Docstring Coverage	❌ Error	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adopting the type-aware Oxc linting and formatting toolchain.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch t3code/add-oxlint-type-aware-linting

✨ Simplify code

Create PR with simplified code
Commit simplified code in branch t3code/add-oxlint-type-aware-linting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@package.json`:
- Around line 27-28: Pin the oxlint dependency in package.json to an exact
version matching the intended type-aware toolchain, replacing the caret range on
oxlint while preserving the existing exact versions for oxlint-tsgolint and
TypeScript.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5dff5778-c9ce-4543-b992-8599b94c0113

📥 Commits

Reviewing files that changed from the base of the PR and between fc02a18 and 7c6bfe7.

⛔ Files ignored due to path filters (1)

bun.lock is excluded by !**/*.lock

📒 Files selected for processing (14)

.oxfmtrc.json
.oxlintrc.json
AGENTS.md
README.md
biome.json
docs/plans/decisions-log.md
index.ts
package.json
src/cli/prepare_image.ts
src/domain/media_process.ts
src/domain/prepare_image.ts
src/domain/prepare_image_layout.ts
tests/integration/prepare_image.integration.test.ts
tests/output_path.test.ts

💤 Files with no reviewable changes (1)

biome.json

📜 Review details

⏰ Context from checks skipped due to timeout. (1)

GitHub Check: Cursor Approval Agent: Pull Request Approver

🧰 Additional context used

📓 Path-based instructions (9)

**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/use-bun-instead-of-node-vite-npm-pnpm.mdc)

**/*.{js,ts,jsx,tsx}: Prioritize using plain JavaScript/TypeScript instead of libraries for fundamental algorithms (e.g., use Array methods instead of lodash)
Use functional programming patterns and immutable data structures in JavaScript/TypeScript code

Files:

tests/output_path.test.ts
src/domain/media_process.ts
src/domain/prepare_image.ts
src/domain/prepare_image_layout.ts
index.ts
src/cli/prepare_image.ts
tests/integration/prepare_image.integration.test.ts

**/*.{ts,tsx}