Handle schemeless URLs in Location
header
#61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #60, we fixed an issue where redirects were path-based, but didn't handle redirects that were schemeless (i.e. they have a host but no scheme). Rather than adding more logic for this, I remembered Python has a built in method --
urljoin()
-- for resolving relative URLs that handles both these cases (and probably a few others, like non-absolute paths). We should have used it in the first place!