Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requests from public interfaces #157

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Remove requests from public interfaces #157

wants to merge 17 commits into from

Commits on Dec 26, 2023

  1. Create new _http module, move hacks to it

    @Mr0grog
    Mr0grog committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    bdbdc06 View commit details
    Browse the repository at this point in the history

  2. Move all *requests* stuff (except errors) to new adapter

    @Mr0grog
    Mr0grog committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    18527aa View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. Update docs for WaybackSession

    @Mr0grog
    Mr0grog committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    01e6d83 View commit details
    Browse the repository at this point in the history

  2. Add InternalHttpResponse to provide a non-requests Response interface 

    This also provides some basic (but not yet fully implemented) thread-safety for response objects.
    @Mr0grog
    Mr0grog committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    1eb3e17 View commit details
    Browse the repository at this point in the history

  3. Delegate to requests for encoding sniffing 

    Also re-organize methods a bit
    @Mr0grog
    Mr0grog committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    ccc8f40 View commit details
    Browse the repository at this point in the history

  4. Fix locking and caching issues in close()

    @Mr0grog
    Mr0grog committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    0f3ef22 View commit details
    Browse the repository at this point in the history

  5. Split response API from reqeusts-specific implementation

    @Mr0grog
    Mr0grog committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    172e6a6 View commit details
    Browse the repository at this point in the history

  6. Add docs and type annotations to adapters

    @Mr0grog
    Mr0grog committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    4843ed4 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Break Session functionality into separate methods 

    Sessions currently handle rate limiting and retries (and *need* to handle redirects so those get rate limited; it's a bug that they do not) and their implementation is a bit complicated. This separates out each of those jobs into a separate method to make management of those separate (but related) tasks a bit clearer. This should make the code a little easier to change, which will probably happen next because I think I want to remove `WaybackSession` entirely.
    @Mr0grog
    Mr0grog committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    9d9a16c View commit details
    Browse the repository at this point in the history

  2. Clarify redirect_url docs

    @Mr0grog
    Mr0grog committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    de28981 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Rename allow_redirects -> follow_redirects

    @Mr0grog
    Mr0grog committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    f2eb7e5 View commit details
    Browse the repository at this point in the history

  2. Limit noqa to just the unused import rule

    @Mr0grog
    Mr0grog committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    086e034 View commit details
    Browse the repository at this point in the history

  3. Add user agent test 

    I think we actually broke this functionality somewhere, so it needs a test
    @Mr0grog
    Mr0grog committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    2f48476 View commit details
    Browse the repository at this point in the history

  4. Move all WaybackSession functionality to adapters

    @Mr0grog
    Mr0grog committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    f43ba0a View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Forgot the dict merge operator is Python 3.9+

    @Mr0grog
    Mr0grog committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    0ec7811 View commit details
    Browse the repository at this point in the history

  2. Delegate default header handling to requests

    @Mr0grog
    Mr0grog committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    cf6d879 View commit details
    Browse the repository at this point in the history

  3. Oops, stream should be true

    @Mr0grog
    Mr0grog committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    994c8b7 View commit details
    Browse the repository at this point in the history