A little more rate limit tweaking for v0.4.4 #142
Merged
Commits on Nov 27, 2023
-
-
Move retry-after header parsing, support full spec
This logic has gotten too complex and is probably going to need multiple call-sites, so it doesn't belong directly in the exception constructor anymore.
-
Always delay at least 60 seconds for 429 responses
The 429 status code is a bit special -- the server is warning us we're going to get blocked if we don't slow it down. At current, the Wayback Machine has a 1 minute window for evaluating good behavior, so instead of pausing for the default backoff time, pause for at least 1 minute (if the default backoff time winds up being more, then pause for that).
-
-
It turns out total_time has always been a lie
I'm not sure how we wound up calculating `total_time` as the sum of delays instead of the actual time taken, but we certainly did, and it makes no sense.
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.