Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flake8 to v6.1.0 #124

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Upgrade Flake8 to v6.1.0 #124

merged 2 commits into from
Sep 20, 2023

Conversation

Mr0grog
Copy link
Member

@Mr0grog Mr0grog commented Sep 18, 2023

Earlier versions of flake8 do not support Python 3.12. Part of #123.

Earlier versions of flake8 do not support Python 3.12. Part of #123.
@Mr0grog Mr0grog mentioned this pull request Sep 18, 2023
4 tasks
@Mr0grog
Copy link
Member Author

Mr0grog commented Sep 18, 2023

Well, this version of flake8 does not support Python < 3.8. Those versions are all end-of-life at this point (https://devguide.python.org/versions/) so this is probably OK. Will need to update the checks and classifiers in setup.py here, too:

wayback/setup.py

Lines 7 to 23 in 1ea1223

# NOTE: This file must remain Python 2 compatible for the foreseeable future,
# to ensure that we error out properly for people with outdated setuptools
# and/or pip.
min_version = (3, 6)
if sys.version_info < min_version:
error = """
wayback does not support Python {0}.{1}.
Python {2}.{3} and above is required. Check your Python version like so:
python3 --version
This may be due to an out-of-date pip. Make sure you have pip >= 9.0.1.
Upgrade pip like so:
pip install --upgrade pip
""".format(*(sys.version_info[:2] + min_version))
sys.exit(error)

@Mr0grog
Copy link
Member Author

Mr0grog commented Sep 18, 2023

Also worth noting: Google Colab has since updated to Python 3.10, so this shouldn't break any Colab stuff.

@Mr0grog
Copy link
Member Author

Mr0grog commented Sep 18, 2023

Trying an alternative by splitting out test dependencies from other dev dependencies, kind of like how we handle docs. Maybe more complex than is healthy, but lets us continue being Python 3.6 compatible (sort of).

@Mr0grog Mr0grog force-pushed the upgrade-flake8-v6.1.0 branch 2 times, most recently from 3441e8f to 39b797e Compare September 20, 2023 16:38
@Mr0grog Mr0grog merged commit 7751ec2 into main Sep 20, 2023
10 checks passed
@Mr0grog Mr0grog deleted the upgrade-flake8-v6.1.0 branch September 20, 2023 20:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant