Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple API endpoints use HTTP instead of HTTPS #81

Closed
sundhaug92 opened this issue Jun 20, 2021 · 1 comment · Fixed by #97
Closed

Multiple API endpoints use HTTP instead of HTTPS #81

sundhaug92 opened this issue Jun 20, 2021 · 1 comment · Fixed by #97

Comments

@sundhaug92
Copy link

sundhaug92 commented Jun 20, 2021

Ex:

Note: Fixing this may require changing the mocks

@Mr0grog
Copy link
Member

Mr0grog commented Jun 22, 2021

Ah! This is because the memento URLs used to redirect from https to http (very surprising, which is why I remember it!). It looks like that’s changed, though, so we should probably make everything HTTPS. Thanks! 👍

I’m also happy to accept a PR if you’d like to make the change.

Mr0grog added a commit that referenced this issue Oct 29, 2022
We used to use HTTP (unsecure) for all archive.org URLs because requesting HTTPS used to redirect to HTTP (making HTTPS kind of a waste). That's no longer the case, and using HTTPS is always a good idea (even if you aren't sending secure info, it helps make sure you are getting legitimate data from the server you expect). Thanks to @sundhaug92 for pointing this out.

Fixes #81.
Mr0grog added a commit that referenced this issue Oct 31, 2022
We used to use HTTP (unsecure) for all archive.org URLs because requesting HTTPS used to redirect to HTTP (making HTTPS kind of a waste). That's no longer the case, and using HTTPS is always a good idea (even if you aren't sending secure info, it helps make sure you are getting legitimate data from the server you expect). Thanks to @sundhaug92 for pointing this out.

Fixes #81.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants