Skip to content

Commit

Permalink
Add urllib3 to test matrix
Browse files Browse the repository at this point in the history
This should fail for urllib3 v2 and pass for v1, since no changes have been made to the actual source code yet, and v2 should be incompatible. First stop on the way to fully fixing #116.
  • Loading branch information
Mr0grog committed Sep 26, 2023
1 parent f7aa5d8 commit fbdc3bd
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
11 changes: 11 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ commands:
parameters:
python-version:
type: string
urllib3-version:
type: string
default: "1"
install-dev:
description: Install dev dependencies (not just test dependencies)
type: boolean
Expand All @@ -31,6 +34,7 @@ commands:
pip install --upgrade pip
pip install .
pip install -r requirements-test.txt # Extra requirements for tests.
pip install urllib3~=<< parameters.urllib3-version >>
# Dev dependencies are only compatible on Python 3.8+, so only install
# them on demand.
Expand Down Expand Up @@ -62,6 +66,8 @@ jobs:
parameters:
python-version:
type: string
urllib3-version:
type: string

working_directory: ~/wayback
docker:
Expand Down Expand Up @@ -186,6 +192,11 @@ workflows:
matrix:
parameters:
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10", "3.11"]
urllib3-version: ["1", "2"]
exclude:
# urllib3v2 is not compatible with Python < 3.7.
- python-version: "3.6"
urllib3-version: "2"
- test-python-prerelease
- lint
- build
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
requests
urllib3 >=1.20, <2
urllib3 >=1.20

0 comments on commit fbdc3bd

Please sign in to comment.