Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discharge monitoring data sets and Watershed region. #42

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Discharge monitoring data sets and Watershed region. #42

merged 1 commit into from
Mar 2, 2023

Conversation

shansen5
Copy link
Collaborator

@shansen5 shansen5 commented Mar 1, 2023

These fairly simple changes have been tested with the ECHO-CrossProgram.

ericnost
ericnost reviewed Mar 1, 2023
View reviewed changes
Copy link
Member

@ericnost ericnost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good Steve, thank you for putting it together!!!

Will it be a problem to drop the "agg_col" and "agg_type" from the SDWA presets? These define which fields in the tables are used for aggregating the data and making charts.

@shansen5 shansen5 merged commit 56ff4e1 into main Mar 2, 2023
@shansen5 shansen5 deleted the discharges branch March 14, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnost ericnost ericnost left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shansen5 @ericnost