Watershed geo #23
Merged
Watershed geo #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shansen5 I haven't tested this across the board, but I think it has been working well in the Watershed notebook, so I believe it can be merged! Worst case we can fix the bugs after the fact. |
|
I think this was merged into 'master' (still the default branch) so we are good. |
|
@shansen5 should we merge this? |
|
Ping on this - should this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this branch focus on allowing multiple selections of region types. This capability is used in ECHO-Watershed, AllPrograms, RegionMaps and ECHO-Cross-Program. Those notebooks all currently begin with a clone of the watershed-geo branch of this ECHO_modules repo. When this is merged into the main branch we can change those modules.