Instead of df_to_map, used my_prog_data #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will update to add style markers soon
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
ericnost
reviewed
Jun 17, 2020
There was a problem hiding this comment.
Thanks @maalvikabhat! The changes look great. I know it looks like we're just changing variable names, but they will make more sense once we merge some of @shansen5's recent edits into the main branch. He has added my_prog_data too, to hold EPA program-specific information. The changes will allow us to map facilities based on e.g.# of Clean Air Act inspections, rather than just pins on the map. So, I'm going to hold off on "approving" and merging your changes until we merge Steve's.
|
Addresses #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will update to add style markers soon