Skip to content

Conversation

@FelixTing
Copy link
Member

fix: #420

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Run core-command with the go-mod-messaging module from this branch, and verify that sending command requests via message bus works properly.

@FelixTing FelixTing requested a review from judehung June 20, 2025 06:02
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.85%. Comparing base (fedb49d) to head (cc91409).

Files with missing lines Patch % Lines
internal/pkg/mqtt/client.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   57.78%   57.85%   +0.07%     
==========================================
  Files          22       22              
  Lines        1163     1165       +2     
==========================================
+ Hits          672      674       +2     
  Misses        437      437              
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@judehung judehung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judehung judehung merged commit 53a0ec2 into edgexfoundry:main Jun 20, 2025
3 checks passed
@FelixTing FelixTing deleted the issue-420 branch June 20, 2025 06:45
FelixTing added a commit to FelixTing/go-mod-messaging that referenced this pull request Oct 14, 2025
FelixTing added a commit to FelixTing/go-mod-messaging that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent error handling in MQTT Client's Unsubscribe method

3 participants