Skip to content

Conversation

@weichou1229
Copy link
Member

Close #623

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.

What is the current behavior?

Issue Number: #623

What is the new behavior?

Add secret route path and HTTP client for adding EdgeX Service exclusive secret to the Secret Store.

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

Add secret route path and HTTP client for adding EdgeX Service exclusive secret to the Secret Store.

Close edgexfoundry#623

Signed-off-by: weichou <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #624 (2bee6ef) into master (6fe3687) will decrease coverage by 0.06%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   56.08%   56.02%   -0.07%     
==========================================
  Files         131      131              
  Lines        3935     3943       +8     
==========================================
+ Hits         2207     2209       +2     
- Misses       1490     1495       +5     
- Partials      238      239       +1     
Impacted Files Coverage Δ
v2/dtos/common/secret.go 62.50% <0.00%> (-20.84%) ⬇️
v2/clients/http/common.go 61.53% <50.00%> (-2.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe3687...2bee6ef. Read the comment docs.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 693d3d1 into edgexfoundry:master May 26, 2021
@weichou1229 weichou1229 deleted the issue-623 branch July 16, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[V2] Add secret route path and HTTP client

3 participants