Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis startup race condition - Not setting up DB credentials #2636

Closed
jpwhitemn opened this issue Jul 22, 2020 · 2 comments
Closed

Redis startup race condition - Not setting up DB credentials #2636

jpwhitemn opened this issue Jul 22, 2020 · 2 comments
Assignees
Labels
bug Something isn't working geneva security-services

Comments

@jpwhitemn
Copy link
Member

🐞 Bug Report

Affected Services

Continuation from #2542 - while fix worked for Geneva, there was a suggestion on the part of Tony and Andre needed for Hanoi going forward:

Tony: Re: [ -s ], isn't it still possible for the the file to be partially written when this check is made? Wouldn't a semaphore file be safer?
Andre: Given the length of the password and the typical I/O buffer, it is unlikely for a partial write to occur.

When Geneva is released, I'm going to rewrite security-secretstore-read to eliminate the password file altogether and set the password directly in Redis.

Is this a regression?

temp solution in Geneva

Description and Minimal Reproduction

see #2542

@hutchic
Copy link
Member

hutchic commented Jul 29, 2020

decided this is a duplicate of #2636 going to track progress on that issue going forward

edit: I meant to link to #2503

@hutchic hutchic closed this as completed Jul 29, 2020
@andresrinivasan
Copy link
Member

@hutchic Did you mean to close this issue (#2636) or a different one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working geneva security-services
Projects
None yet
Development

No branches or pull requests

3 participants