[frontend] Add Update Channels #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebriani
requested changes
Mar 1, 2023
Comment on lines
+52
to
+70
| const TargetGroupsErrors = ({ errors }: { errors: unknown }) => { | ||
| if (errors == null) { | ||
| return null; | ||
| } | ||
| if (typeof errors === "object" && !Array.isArray(errors)) { | ||
| if ( | ||
| "message" in errors && | ||
| typeof (errors as Record<"message", unknown>).message === "string" | ||
| ) { | ||
| const message = (errors as Record<"message", string>).message; | ||
| return <FormattedMessage id={message} />; | ||
| } | ||
| } | ||
| return null; | ||
| }; |
There was a problem hiding this comment.
Not sure if this component with all this code is really necessary. I wonder if following the pattern already used for the other error messages would keep the code leaner and clearer:
errors.targetGroups?.message && <FormattedMessage id={errors.targetGroups.message} />
There was a problem hiding this comment.
RHF does not return valid type for targetGroups validation errors so we need to type guard it.
I've added comment with more detailed explanation and TODO note.
davidebriani
requested changes
Mar 1, 2023
szakhlypa
force-pushed
the
frontend-update-channels
branch
from
60e68ac
to
780ec46
Compare
Pull Request Test Coverage Report for Build 4488882488
💛 - Coveralls |
npm run relay:generate-schema npm run format Signed-off-by: Sergey Zakhlypa <[email protected]>
add stubbed data to mock Relay's responses for UpdateChannel queries Signed-off-by: Sergey Zakhlypa <[email protected]>
Add the UpdateChannelsTable React component Signed-off-by: Sergey Zakhlypa <[email protected]>
Add a page a fetch and list available Update Channels Signed-off-by: Sergey Zakhlypa <[email protected]>
npm update react-select Signed-off-by: Sergey Zakhlypa <[email protected]>
Add optional properties: - `creatable` to configure if new options can be created - `invalid` to style component with `MultiSelect.scss` - `getOptionLabel` to pass custom label resolver - `getOptionValue` to pass custom value resolver - `isOptionDisabled` with logic to detect whether an option is disabled - `onBlur` callback to call on blur event Signed-off-by: Sergey Zakhlypa <[email protected]>
szakhlypa
force-pushed
the
frontend-update-channels
branch
from
780ec46
to
3f83dac
Compare
Pavinati
approved these changes
Mar 30, 2023
davidebriani
requested changes
Mar 30, 2023
Comment on lines
+173
to
+186
| <SidebarItem | ||
| label={ | ||
| <FormattedMessage | ||
| id="components.Sidebar.updateChannelsLabel" | ||
| defaultMessage="Update Channels" | ||
| /> | ||
| } | ||
| route={Route.updateChannels} | ||
| activeRoutes={[ | ||
| Route.updateChannels, | ||
| Route.updateChannelsEdit, | ||
| Route.updateChannelsNew, | ||
| ]} | ||
| /> |
There was a problem hiding this comment.
Putting the Update Channels under the Models menu group feels a bit odd.
We could have a separate Software Updates menu group that includes Update Channels, and maybe also Base Image Collections.
There was a problem hiding this comment.
We will review Sidebar menu groups after first implementation of fleet operations.
Add a page with a form to view and edit Update Channel Signed-off-by: Sergey Zakhlypa <[email protected]>
Add a page with a form to create Update Channel Signed-off-by: Sergey Zakhlypa <[email protected]>
npm run i18n:extract Signed-off-by: Sergey Zakhlypa <[email protected]>
Signed-off-by: Sergey Zakhlypa <[email protected]>
szakhlypa
force-pushed
the
frontend-update-channels
branch
from
3f83dac
to
ff839bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds forms and logic to create, update and delete
Update Channels.Create
Update Channel:update.channel.create.mp4
Create
Update Channel(disabled target groups are in use for otherUpdate Channels):update.channel.create.some.tagret.groups.are.disabled.mp4
Update and delete
Update Channel:update.and.delete.update.channel.mp4