Update OTARequest interface #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlem88
force-pushed
the
ota-request-update
branch
2 times, most recently
from
8b02c4e
to
12914c1
Compare
rbino
approved these changes
May 10, 2023
szakhlypa
reviewed
May 10, 2023
Change reliability to unreliable on `io.edgehog.devicemanager.OTARequest` interface, since `unreliable` is the default value, the reliability param was removed from the interface. Reliability changing involve also a bump of version major. Signed-off-by: Antonio Gisondi <[email protected]>
harlem88
force-pushed
the
ota-request-update
branch
2 times, most recently
from
fd69d63
to
f5b3c9f
Compare
szakhlypa
suggested changes
May 10, 2023
Add endpoint `operation` to `io.edgehog.devicemanager.OTARequest.json` interface. Signed-off-by: Antonio Gisondi <[email protected]>
harlem88
force-pushed
the
ota-request-update
branch
from
f5b3c9f
to
afca949
Compare
szakhlypa
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51, closes #52.